Skip to content

Commit 6d3ecf8

Browse files
committed
HHH-16900 Refactor integration tests
1 parent 563afe7 commit 6d3ecf8

File tree

1 file changed

+37
-23
lines changed

1 file changed

+37
-23
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/boot/database/qualfiedTableNaming/DefaultCatalogAndSchemaTest.java

Lines changed: 37 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
import org.hibernate.query.sqm.mutation.internal.temptable.LocalTemporaryTableStrategy;
4848
import org.hibernate.query.sqm.mutation.internal.temptable.PersistentTableStrategy;
4949
import org.hibernate.service.spi.ServiceRegistryImplementor;
50+
import org.hibernate.sql.model.MutationOperation;
5051
import org.hibernate.sql.model.MutationOperationGroup;
5152
import org.hibernate.sql.model.PreparableMutationOperation;
5253
import org.hibernate.tool.hbm2ddl.SchemaExport;
@@ -408,38 +409,51 @@ private void verifyEntityPersisterQualifiers(Class<?> entityClass, ExpectedQuali
408409
// This will include SQL generated by ID generators in some cases, which will be validated here
409410
// because ID generators table/sequence names are prefixed with the owning entity name.
410411

411-
final MutationOperationGroup staticSqlInsertGroup = persister.getInsertCoordinator().getStaticInsertGroup();
412-
final String[] insertSqls = new String[ staticSqlInsertGroup.getNumberOfOperations()];
413-
staticSqlInsertGroup.forEachOperation( (tablePosition, insertOperation) -> {
414-
if ( insertOperation instanceof PreparableMutationOperation ) {
415-
insertSqls[tablePosition] = ( (PreparableMutationOperation) insertOperation ).getSqlString();
412+
{
413+
final MutationOperationGroup staticSqlInsertGroup = persister.getInsertCoordinator().getStaticInsertGroup();
414+
final String[] insertSqls = new String[staticSqlInsertGroup.getNumberOfOperations()];
415+
for ( int tablePosition = 0;
416+
tablePosition < staticSqlInsertGroup.getNumberOfOperations();
417+
tablePosition++ ) {
418+
final MutationOperation insertOperation = staticSqlInsertGroup.getOperation( tablePosition );
419+
if ( insertOperation instanceof PreparableMutationOperation ) {
420+
insertSqls[tablePosition] = ( (PreparableMutationOperation) insertOperation ).getSqlString();
421+
}
416422
}
417-
} );
418-
419-
verifyOnlyQualifier( insertSqls, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
423+
verifyOnlyQualifier( insertSqls, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
424+
}
420425

421426
String identitySelectString = persister.getIdentitySelectString();
422427
if ( identitySelectString != null ) {
423428
verifyOnlyQualifierOptional( identitySelectString, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
424429
}
425430

426-
final MutationOperationGroup staticSqlUpdateGroup = persister.getUpdateCoordinator().getStaticUpdateGroup();
427-
final String[] sqlUpdateStrings = new String[staticSqlUpdateGroup.getNumberOfOperations()];
428-
staticSqlUpdateGroup.forEachOperation( (tablePosition, operation) -> {
429-
if ( operation instanceof PreparableMutationOperation ) {
430-
sqlUpdateStrings[tablePosition] = ( (PreparableMutationOperation) operation ).getSqlString();
431+
{
432+
final MutationOperationGroup staticSqlUpdateGroup = persister.getUpdateCoordinator().getStaticUpdateGroup();
433+
final String[] sqlUpdateStrings = new String[staticSqlUpdateGroup.getNumberOfOperations()];
434+
for ( int tablePosition = 0;
435+
tablePosition < staticSqlUpdateGroup.getNumberOfOperations();
436+
tablePosition++ ) {
437+
final MutationOperation operation = staticSqlUpdateGroup.getOperation( tablePosition );
438+
if ( operation instanceof PreparableMutationOperation ) {
439+
sqlUpdateStrings[tablePosition] = ( (PreparableMutationOperation) operation ).getSqlString();
440+
}
431441
}
432-
} );
433-
verifyOnlyQualifier( sqlUpdateStrings, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
434-
435-
final MutationOperationGroup staticDeleteGroup = persister.getDeleteCoordinator().getStaticDeleteGroup();
436-
final String[] sqlDeleteStrings = new String[staticDeleteGroup.getNumberOfOperations()];
437-
staticDeleteGroup.forEachOperation( (tablePosition, operation) -> {
438-
if ( operation instanceof PreparableMutationOperation ) {
439-
sqlDeleteStrings[tablePosition] = ( (PreparableMutationOperation) operation ).getSqlString();
442+
verifyOnlyQualifier( sqlUpdateStrings, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
443+
}
444+
445+
446+
{
447+
final MutationOperationGroup staticDeleteGroup = persister.getDeleteCoordinator().getStaticDeleteGroup();
448+
final String[] sqlDeleteStrings = new String[staticDeleteGroup.getNumberOfOperations()];
449+
for ( int tablePosition = 0; tablePosition < staticDeleteGroup.getNumberOfOperations(); tablePosition++ ) {
450+
final MutationOperation operation = staticDeleteGroup.getOperation( tablePosition );
451+
if ( operation instanceof PreparableMutationOperation ) {
452+
sqlDeleteStrings[tablePosition] = ( (PreparableMutationOperation) operation ).getSqlString();
453+
}
440454
}
441-
} );
442-
verifyOnlyQualifier( sqlDeleteStrings, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
455+
verifyOnlyQualifier( sqlDeleteStrings, SqlType.RUNTIME, jpaEntityName, expectedQualifier );
456+
}
443457

444458
// This is used in the "select" id generator in particular.
445459
verifyOnlyQualifierOptional( persister.getSelectByUniqueKeyString( "basic" ), SqlType.RUNTIME,

0 commit comments

Comments
 (0)