Pass binary parameter data without copying #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. This is a lot cleaner now, I can see what's the patch actually does! Have you tried this patch (on top of the refactoring) with PostgREST already? |
|
No, not yet. I'll let you know when that happens. |
|
@robx have you had chance to check it? |
Not so far, no. Just rebased the patch on top of current master. EDIT: PostgREST/postgrest#2599 validates the change in PostgREST CI. |
This was referenced Dec 29, 2022
|
I released I'll give it some time to propagate (e.g. enter Stackage), and if it all looks fine I'll merge this and #19 and make another release. |
|
Rebased (+ rerun CI) in #47 and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the core change of #22, ported to current master. Compared to when I first filed this, the change has been used in PostgREST and hasn't caused problems there, for whatever that's worth.