Skip to content

match documentation to upstream C library #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2019
Merged

match documentation to upstream C library #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3903ee6
fix documentation for `resultErrorMessage`
bergey Jul 1, 2019
f0cb7f1
document that `ntuples` does not risk overflow
bergey Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Database/PostgreSQL/LibPQ.hsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,8 +1045,8 @@ resStatus es =
return $ B.fromForeignPtr fp 0 $ fromIntegral len


-- | Returns the error message most recently generated by an operation
-- on the connection.
-- | Returns the error message associated with the command, or an
-- empty string if there was no error.
resultErrorMessage :: Result
-> IO (Maybe B.ByteString)
resultErrorMessage = flip maybeBsFromResult c_PQresultErrorMessage
Expand Down Expand Up @@ -1203,9 +1203,9 @@ resultErrorField (Result fp) fieldcode =
-- values, these functions will act as though the result has zero rows
-- and zero columns.

-- | Returns the number of rows (tuples) in the query result. Because
-- it returns an integer result, large result sets might overflow the
-- return value on 32-bit operating systems.
-- | Returns the number of rows (tuples) in the query result. (Note
-- that PGresult objects are limited to no more than INT_MAX rows, so
-- an int result is sufficient.)
ntuples :: Result
-> IO Row
ntuples res = withResult res (return . toRow . c_PQntuples)
Expand Down