Bundle using Webpack (2) #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismwendt
force-pushed
the
webpack
branch
2 times, most recently
from
6417807 to
0d89f15
Compare
|
Looks Good 👍 |
|
@chrismwendt can you update this against current master, then we can get a new release out quite soon. |
|
Rebased on master, fixed merge conflicts. |
|
The build seemingly stalls only on macOS https://travis-ci.org/alanz/vscode-hie-server/jobs/607470418#L173 |
alanz
reviewed
Nov 5, 2019
alanz
reviewed
Nov 5, 2019
|
Thanks for fighting this one through |
This was referenced Nov 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR was accidentally closed #159
Resolves #151
Fixes #137
I pretty much just followed https://code.visualstudio.com/api/working-with-extensions/bundling-extension. I also swapped
lodashforlodash-es, which reduces the bundle size by ~20%..vsixsize: 2MB -> 400KBI verified that breakpoints still get hit, and the extension still activates and provides hover tooltips.
Unfortunately, https://github.com/eamodio/vscode-tsl-problem-matcher didn't work, so I copied the
problemMatcherdefinition.