Skip to content

Wingman/tactics "hole_severity" option is broken #502

Closed
@mirko-plowtech

Description

@mirko-plowtech

VS code doesn't allow to setup number options due to a "Invalid type. Expected string"

        "haskell.plugin.tactics.config.hole_severity": {
          "enumDescriptions": [
            "error",
            "warning",
            "info",
            "hint",
            "none"
          ],
          "scope": "resource",
          "description": "The severity to use when showing hole diagnostics.",
          "enum": [
            1,
            2,
            3,
            4,
            null
          ],
          "default": null,
          "type": "string"
        },

^ 1,2, 3, 4 are integers, but "validation" requires string.

  • Op 1. It should use integer (btw, instead of null it could use 0)
  • Op 2. It should use "1","2", "3", "4"

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugA bug or unintended effect

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions