executableExists assumes the existance of "which"

[expipiplus1]

If which isn't in the PATH it should probably not fail saying that the queried executable isn't available, very confusing!

[jneira]

or windows 🤔 It uses where/which

could you link the code if you have it at hand, please?

vscode-haskell/src/utils.ts

Lines 207 to 212 in 518d34f

	export function executableExists(exe: string): boolean {
	const isWindows = process.platform === 'win32';
	const cmd: string = isWindows ? 'where' : 'which';
	const out = child_process.spawnSync(cmd, [exe]);
	return out.status === 0 || (isWindows && fs.existsSync(exe));
	}

@expipiplus1 in which concrete cases is probable to not have it in $PATH?

[expipiplus1]

@jneira I bumped into this in a nix build which didn't list pkgs.which as a build input.

[michaelpj]

I also just hit this. In my case I was trying to build a docker devcontainer with HLS and hadn't put which in there. Spent a good couple of hours tearing my hair out about what was wrong with the PATH until I read the extension source! It's a niche case but quite painful when it comes up 😅

[jneira]

@expipiplus1 @michaelpj hi! i've prepared a fix with #518, could you got the chance of test the pr vsix to check if it fix the issue in your envs?

https://github.com/haskell/vscode-haskell/suites/4605389050/artifacts/124395850

[jneira]

checked manually in wsl

[expipiplus1]

thanks @jneira!