Skip to content

Some minor changes #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Some minor changes #61

merged 4 commits into from
Apr 10, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Apr 9, 2020

  • More renaming hie to hls
  • Add -j argument to control the number of threads
  • Show arguments and plugins when starting lsp server

@jneira
Copy link
Member Author

jneira commented Apr 10, 2020

The output is somewhat dev oriented:

Starting (haskell-language-server)LSP server...
  with arguments: Arguments {argLSP = True, argsCwd = Nothing, argFiles = [], argsVersion = False, argsShakeProfiling = Nothing, argsTesting = False, argsExamplePlugin = False, argsDebugOn = True, argsLogFile = Just "C:\\TEMP\\hls.log", argsThread = 1}
  with plugins: [PluginId "floskell",PluginId "ghcide",PluginId "ormolu",PluginId "pragmas"]

but i think we could keep it for final users, pretty printing it:

Starting (haskell-language-server)LSP server...
  with arguments: "--lsp --debug --logfile="C:\\TEMP\\hls.log --thread=1"
  with plugins: floskell, ghcide, ormolu, pragmas

@jneira jneira requested a review from alanz April 10, 2020 10:44
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to see some contributions here

@alanz alanz merged commit 5570da9 into haskell:master Apr 10, 2020
@jneira jneira deleted the minor-changes branch April 10, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants