Skip to content

Use latest fourmolu #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

googleson78
Copy link
Contributor

My motivation for this is that the latest fourmolu has more config options which I want to use.

@googleson78
Copy link
Contributor Author

Hm, maybe the formatting changed since that version, and so I need to just change the test?

@googleson78
Copy link
Contributor Author

Also I'm not sure if configs are being loaded correctly, need to investigate.

@georgefst
Copy link
Collaborator

Thanks for having a go at this!

This is very much on my radar. We've just got one more patch to go in before we finally make a major release. I'd expect that'll be on Hackage by the weekend. And I've already rewritten the HLS plugin locally. Perhaps I should have put that here as a draft PR to save you the time. In general, I'll be pretty vigilant about keeping this up to date, since HLS is also the main way I interact with Fourmolu.

@georgefst
Copy link
Collaborator

Yeah, the test is broken because the default is now to respect import groups.

But anyway, this should unfortunately probably be closed in favour of the PR I'll be opening in a few days.

This was referenced Oct 2, 2020
@googleson78
Copy link
Contributor Author

is subsumed by #455

@googleson78 googleson78 closed this Oct 3, 2020
pepeiborra added a commit that referenced this pull request Dec 27, 2020
Previously PathIdMap cached NormalizedFilePath values, but with the addition of
module data those got dropped.

It's probably a good idea to bring those back to avoid the risk of a perf
regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants