Fix -Wall and -Wunused-packages in hls-class-plugin #3972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Jan 17, 2024
| addMethodDecls ps mDecls range withSig | ||
| | withSig = go (concatMap (\(decl, sig) -> [sig, decl]) mDecls) | ||
| | otherwise = go (map fst mDecls) | ||
| where | ||
| go inserting = do | ||
| allDecls <- hsDecls ps | ||
| let (before, ((L l inst): after)) = break (inRange range . getLoc) allDecls | ||
| replaceDecls ps (before ++ (L l (addWhere inst)): (map newLine inserting ++ after)) | ||
| case break (inRange range . getLoc) allDecls of |
There was a problem hiding this comment.
This and next hunk fix incomplete-uni-patterns warnings.
jhrcek
commented
Jan 17, 2024
| @@ -190,7 +190,6 @@ getInstanceBindLensRule recorder = do | |||
| (locA l) -- bindSpan | |||
| (locA l') -- bindNameSpan | |||
| in toBindInfo <$> filter (\(L _ name) -> unLoc name `notElem` sigNames) bindNames | |||
| getBindSpanWithoutSig _ = [] | |||
There was a problem hiding this comment.
Removing overlapping pattern match.
michaelpj
approved these changes
Jan 17, 2024
josephsumabat
pushed a commit
to josephsumabat/haskell-language-server
that referenced
this pull request
Jan 22, 2024
* Fix -Wunused-packages in class plugin * -Wall and hlint fixes * Fix type annotation for ghc 9.6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.