-
-
Notifications
You must be signed in to change notification settings - Fork 397
Remove unused dependencies in hls-refactor-plugin #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependencies in hls-refactor-plugin #3953
Conversation
LGTM, I support such changes |
This is very useful. I definitely think we could turn on a lot more warnings generally. I think it's probably worth putting |
Can do. What would be your general preference for doing that (so we have some consistency) across packages.
and then importing for each target? |
Our plugins are pretty inconsistent in general, since they were often written by different people. Adding some consistency would be lovely. I personally like common stanzas for stuff like |
046b66b
to
3290d18
Compare
I'll work on making these more consistent across multiple plugins, but it's too easy to get sidetracked trying to fix too many things at once. So let me try to maintain laser-focus on fixing unused-packages in as many places as possible and we can agree on how to enforce it consistently at later stage. |
3290d18
to
cb91bac
Compare
* Remove unused dependencies in hls-refactor-plugin * Don't use CPP at all
I'd like to do general cleanup of unused dependencies (stuff reported by
-Wunused-packages
).This PR starts by just doing this for one plugin and checking that people agree with the approach to removing unused ghc (direct - I know that most plugins actually do depend on GHC transitively) dependency.
If you find such initiative useful, I can continue with other plugins.