Skip to content

Update docs about support status #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions docs/support/ghc-version-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ Support status (see the support policy below for more details):

| GHC version | Last supporting HLS version | Support status |
|--------------|------------------------------------------------------------------------------------|-----------------------------------------------------------------------------|
| 9.6.1 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | basic support |
| 9.4.4 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.3 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.2 | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | full support |
| 9.4.1 | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | full support |
| 9.2.6 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.2.5 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.2.4 | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | full support |
| 9.2.3 | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | full support |
| 9.4.3 | [1.9.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.9.1.0) | deprecated |
| 9.4.(1,2) | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | deprecated |
| 9.2.7 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.2.(5,6) | [1.9.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.9.1.0) | deprecated |
| 9.2.(3,4) | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0) | deprecated |
| 9.2.(1,2) | [1.7.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.7.0.0) | deprecated |
| 9.0.2 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.0.1 | [1.6.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.6.1.0) | deprecated |
Expand Down
16 changes: 8 additions & 8 deletions docs/support/plugin-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,18 @@ For example, a plugin to provide a formatter which has itself been abandoned has
| `hls-eval-plugin` | 2 | |
| `hls-explicit-fixity-plugin` | 2 | |
| `hls-explicit-record-fields-plugin` | 2 | |
| `hls-floskell-plugin` | 2 | |
| `hls-fourmolu-plugin` | 2 | |
| `hls-floskell-plugin` | 2 | 9.6 |
| `hls-fourmolu-plugin` | 2 | 9.6 |
| `hls-gadt-plugin` | 2 | |
| `hls-hlint-plugin` | 2 | |
| `hls-hlint-plugin` | 2 | 9.6 |
| `hls-module-name-plugin` | 2 | |
| `hls-qualify-imported-names-plugin` | 2 | |
| `hls-ormolu-plugin` | 2 | |
| `hls-ormolu-plugin` | 2 | 9.6 |
| `hls-rename-plugin` | 2 | |
| `hls-refine-imports-plugin` | 2 | |
| `hls-stylish-haskell-plugin` | 2 | |
| `hls-tactics-plugin` | 2 | 9.2, 9.4 |
| `hls-haddock-comments-plugin` | 3 | 9.2, 9.4 |
| `hls-stan-plugin` | 3 | 8.6, 9.0, 9.2, 9.4 |
| `hls-stylish-haskell-plugin` | 2 | 9.6 |
| `hls-tactics-plugin` | 2 | 9.2, 9.4, 9.6 |
| `hls-haddock-comments-plugin` | 3 | 9.2, 9.4, 9.6 |
| `hls-stan-plugin` | 3 | 8.6, 9.0, 9.2, 9.4, 9.6 |
| `hls-retrie-plugin` | 3 | |
| `hls-splice-plugin` | 3 | |
6 changes: 0 additions & 6 deletions ghcide/src/Development/IDE/Main.hs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ data Log
| LogLspStart [PluginId]
| LogLspStartDuration !Seconds
| LogShouldRunSubset !Bool
| LogOnlyPartialGhc94Support
| LogSetInitialDynFlagsException !SomeException
| LogService Service.Log
| LogShake Shake.Log
Expand All @@ -159,8 +158,6 @@ instance Pretty Log where
"Started LSP server in" <+> pretty (showDuration duration)
LogShouldRunSubset shouldRunSubset ->
"shouldRunSubset:" <+> pretty shouldRunSubset
LogOnlyPartialGhc94Support ->
"Currently, HLS supports GHC 9.4 only partially. See [issue #3190](https://github.com/haskell/haskell-language-server/issues/3190) for more detail."
LogSetInitialDynFlagsException e ->
"setInitialDynFlags:" <+> pretty (displayException e)
LogService log -> pretty log
Expand Down Expand Up @@ -341,9 +338,6 @@ defaultMain recorder Arguments{..} = withHeapStats (cmapWithPrio LogHeapStats re
, optRunSubset = runSubset
}
caps = LSP.resClientCapabilities env
-- FIXME: Remove this after GHC 9.4 gets fully supported
when (ghcVersion == GHC94) $
log Warning LogOnlyPartialGhc94Support
monitoring <- argsMonitoring
initialise
(cmapWithPrio LogService recorder)
Expand Down