Fix action removes ticks from TemplateHaskellQuotes (#628) #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendo
force-pushed
the
fix-628-replace-with-removes-ticks
branch
from
679388f to
7235aad
Compare
michaelpj
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Could we add a bit of commentary? Evidently what's going on is that sometimes GHC will give us... the wrong name, or something? Or is the issue that there's some information about what type of name it is, or how it's used, that we should be detecting and passing along? I would sort of expect this information to be in the GHC AST... but maybe we're not using that.
Basically, I'm clueless, and I wonder if there's some knowledge we should be recording here.
bendo
force-pushed
the
fix-628-replace-with-removes-ticks
branch
3 times, most recently
from
f59e538 to
6c154b0
Compare
|
@michaelpj I've added comment with some example as well. Please review. Thanks |
|
Great, thanks! |
bendo
force-pushed
the
fix-628-replace-with-removes-ticks
branch
from
4b2bfd1 to
4cb60fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.