Skip to content

Remove unused build-depends and install warnings #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Remove unused build-depends and install warnings #3155

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bccc8e
Remove unused build-depends and install warnings
pepeiborra Sep 14, 2022
3c20e01
Merge branch 'master' into unused-packages
pepeiborra Sep 14, 2022
375521d
Remove -Werror
pepeiborra Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghcide-bench/ghcide-bench.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ test-suite test
implicit-hie:gen-hie
main-is: Main.hs
hs-source-dirs: test
ghc-options: -Wunused-packages
ghc-options: -Wunused-packages -Werror=unused-packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably don't want the Werror? Or can we do this only in CI? any kind of Werror is a huge pain during development IMO

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, don't we already have a pedantic cabal flag that we set to enable Werror during CI?

ghc-options: -threaded -Wall
build-depends:
base,
Expand Down
22 changes: 8 additions & 14 deletions ghcide/ghcide.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ library
hiedb == 0.4.2.*,
lsp-types ^>= 1.6.0.0,
lsp ^>= 1.6.0.0 ,
monoid-subclasses,
mtl,
optparse-applicative,
parallel,
Expand Down Expand Up @@ -230,6 +229,9 @@ library
exposed-modules:
Development.IDE.GHC.Compat.CPP

if impl(ghc >= 9)
ghc-options: -Wunused-packages -Werror=unused-packages

if flag(ekg)
build-depends:
ekg-wai,
Expand Down Expand Up @@ -271,28 +273,15 @@ executable ghcide
"-with-rtsopts=-I0 -A128M -T"
main-is: Main.hs
build-depends:
hiedb,
aeson,
base == 4.*,
data-default,
directory,
extra,
filepath,
gitrev,
safe-exceptions,
ghc,
hashable,
lsp,
lsp-types,
heapsize,
hie-bios,
hls-plugin-api,
ghcide,
lens,
optparse-applicative,
hls-graph,
text,
unordered-containers,
other-modules:
Arguments
Paths_ghcide
Expand Down Expand Up @@ -322,6 +311,9 @@ executable ghcide
ekg-wai,
ekg-core,
cpp-options: -DMONITORING_EKG
if impl(ghc >= 9)
ghc-options: -Wunused-packages -Werror=unused-packages


test-suite ghcide-tests
type: exitcode-stdio-1.0
Expand Down Expand Up @@ -378,6 +370,8 @@ test-suite ghcide-tests
record-hasfield
if impl(ghc < 9.3)
build-depends: ghc-typelits-knownnat
if impl(ghc >= 9)
ghc-options: -Wunused-packages
hs-source-dirs: test/cabal test/exe test/src
ghc-options: -threaded -Wall -Wno-name-shadowing -O0 -Wno-unticked-promoted-constructors
main-is: Main.hs
Expand Down
6 changes: 4 additions & 2 deletions hls-graph/hls-graph.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ library
, js-flot
, js-jquery
, list-t
, primitive
, stm
, stm-containers
, time
Expand All @@ -91,7 +90,8 @@ library
template-haskell
if flag(stm-stats)
cpp-options: -DSTM_STATS

if impl(ghc >= 9)
ghc-options: -Wunused-packages -Werror=unused-packages

ghc-options:
-Wall -Wredundant-constraints -Wno-name-shadowing
Expand Down Expand Up @@ -136,3 +136,5 @@ test-suite tests
, text
, unordered-containers
build-tool-depends: hspec-discover:hspec-discover -any
if impl(ghc >= 9)
ghc-options: -Wunused-packages -Werror=unused-packages
3 changes: 2 additions & 1 deletion hls-plugin-api/hls-plugin-api.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ library
, lsp ^>=1.6.0.0
, opentelemetry >=0.4
, optparse-applicative
, process
, regex-tdfa >=1.3.1.0
, text
, transformers
Expand All @@ -70,6 +69,8 @@ library

if flag(pedantic)
ghc-options: -Werror
if impl(ghc >= 9)
ghc-options: -Wunused-packages -Werror=unused-packages

default-language: Haskell2010
default-extensions:
Expand Down