Skip to content

Only run the pre-commit hook on changed files #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 18, 2022
Merged

Only run the pre-commit hook on changed files #3145

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2583afc
Only run the pre-commit hook on changed files
drsooch Sep 7, 2022
66dae39
Let's change a haskell file
drsooch Sep 7, 2022
eaf9f2e
Didn't use the PATTERN field correctly
drsooch Sep 7, 2022
3c07cf1
Move pre-commit block before building stylish-haskell
drsooch Sep 7, 2022
94717b5
Try to evaluate GIT_DIFF value to pass to pre-commit
drsooch Sep 7, 2022
a74b699
Try to evaluate GIT_DIFF value to pass to pre-commit
drsooch Sep 7, 2022
14355fb
Move pre-commit action back to original spot
drsooch Sep 7, 2022
b8bbbc9
Introduce bad formatting in a file
drsooch Sep 7, 2022
b3eb1ed
Conditionally run the pre-commit job only when there are haskell source
drsooch Sep 7, 2022
572a756
Restore haskell files we used for testing
drsooch Sep 7, 2022
9910887
workflow fixes
drsooch Sep 7, 2022
a8d928d
Try changing haskell source files with new workflow structure
drsooch Sep 7, 2022
998bbb5
Revert all changes to files during testing
drsooch Sep 8, 2022
925857a
Merge branch 'master' into pre-commit-workflow-on-changed-files-only
drsooch Sep 8, 2022
ee7c8bd
Merge branch 'master' into pre-commit-workflow-on-changed-files-only
pepeiborra Sep 14, 2022
fc33ba2
Merge branch 'master' into pre-commit-workflow-on-changed-files-only
pepeiborra Sep 18, 2022
2719625
Merge branch 'master' into pre-commit-workflow-on-changed-files-only
pepeiborra Sep 18, 2022
5e8d7e0
Merge branch 'master' into pre-commit-workflow-on-changed-files-only
pepeiborra Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,24 @@ on:
branches: [master]

jobs:
file-diff:
runs-on: ubuntu-latest
outputs:
git-diff: ${{ steps.git-diff.outputs.diff }}
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Find changed files
uses: technote-space/get-diff-action@v4.0.1
id: git-diff
with:
PATTERNS: |
+(src|exe|test|ghcide|plugins|hls-plugin-api|hie-compat|hls-graph|hls-test-utils)/**/*.hs
pre-commit:
runs-on: ubuntu-latest
needs: file-diff
steps:
- uses: actions/checkout@v3

- uses: ./.github/actions/setup-build
with:
os: ${{ runner.os }}
Expand Down Expand Up @@ -40,3 +53,5 @@ jobs:

- uses: actions/setup-python@v4
- uses: pre-commit/action@v3.0.0
with:
extra_args: --files ${{ needs.file-diff.outputs.git-diff }}