Skip to content

Simplify hlint config #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 9 additions & 48 deletions .hlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,19 @@

# Partial functions

# For some reason we need to check fucntions which
# We need to check fucntions which
# are typically exported multiple ways under both names,
# see https://github.com/ndmitchell/hlint/issues/1389
- name: Prelude.head
- name: [Prelude.head, Data.List.head]
within:
- Main
- Experiments
- Development.Benchmark.Rules
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.Completions
- Development.IDE.Plugin.CodeAction.ExactPrint
- Development.IDE.Spans.Documentation
- Development.IDE.Session
- Ide.Plugin.CallHierarchy.Internal
- Ide.Plugin.Eval.Code
- Ide.Plugin.Eval.Util
Expand All @@ -109,42 +111,18 @@
- Typeclass
- Wingman.Judgements
- Wingman.Machinery

- name: Data.List.head
within:
- Main
- Experiments
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.Completions
- Development.IDE.Plugin.CodeAction.ExactPrint
- Development.IDE.Session
- Development.IDE.Spans.Documentation
- Ide.Plugin.CallHierarchy.Internal
- Ide.Plugin.Class
- Wingman.Tactics
- TExpectedActual
- TRigidType

- name: Prelude.tail
- name: [Prelude.tail, Data.List.tail]
within:
- Main
- Development.Benchmark.Rules
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.CodeAction.ExactPrint
- UnificationSpec

- name: Data.List.tail
within:
- Main
- Development.Benchmark.Rules
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.CodeAction.ExactPrint
- Development.IDE.Session
- IDE.Plugin.Eval.Code
- IDE.Plugin.Eval.Util
- UnificationSpec

- name: Prelude.last
- name: [Prelude.last, Data.List.last]
within:
- Main
- Development.IDE.Plugin.CodeAction
Expand All @@ -155,12 +133,7 @@
- Ide.Plugin.Eval.Parse.Comments
- Ide.Plugin.Eval.CodeLens

- name: Data.List.last
within:
- GenChangelogs
- Main

- name: Prelude.init
- name: [Prelude.init, Data.List.init]
within:
- Main
- Development.IDE.Spans.Common
Expand All @@ -169,33 +142,21 @@
- Development.Benchmark.Rules
- ErrorGivenPartialSignature

- name: Data.List.init
within: []

- name: Data.List.foldl1'
within: []

- name: Data.List.foldr1'
within: []

- name: "Prelude.!!"
- name: ["Prelude.!!", "Data.List.!!"]
within:
- Main
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.Completions.Logic
- Development.IDE.Spans.Documentation
- TErrorGivenPartialSignature
- Wingman.CaseSplit
- Wingman.Simplify

- name: "Data.List.!!"
within:
- Main
- Experiments
- FunctionalCodeAction
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.Completions.Logic
- Development.IDE.Spans.Documentation
- TErrorGivenPartialSignature
- Wingman.CaseSplit
- Wingman.Simplify

Expand Down