Skip to content

Fix off by one indexing error in openingBacktick #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix off by one indexing error in openingBacktick #2629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5137f5f
Fix off by one indexing error
pepeiborra Jan 23, 2022
5e1499f
Merge branch 'master' into fix-openingBacktick
mergify[bot] Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghcide/src/Development/IDE/Plugin/Completions/Logic.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ isUsedAsInfix line prefixMod prefixText pos

openingBacktick :: T.Text -> T.Text -> T.Text -> Position -> Bool
openingBacktick line prefixModule prefixText Position { _character=(fromIntegral -> c) }
| backtickIndex < 0 || backtickIndex > T.length line = False
| backtickIndex < 0 || backtickIndex >= T.length line = False
| otherwise = (line `T.index` backtickIndex) == '`'
where
backtickIndex :: Int
Expand Down