Skip to content

Retrieve Type from typecheck result for type lenses #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

berberman
Copy link
Collaborator

Closes #1468 and #622

Parsing error messages from GHC would be tricky, so let's render signatures by ourselves, using information from typecheck. I'll add tests later.

@pepeiborra
Copy link
Collaborator

Can we have tests for non trivial things like:

  1. Polymorphic types
  2. Rank-n types and other types with forall
  3. Types with identifiers out of scope
  4. Types with type operators
  5. Types with promoted constructors and literals

We know that GHC error messages can handle all of the above, by definition, but we need to make sure that the solution in this PR can as well.

@berberman
Copy link
Collaborator Author

Is it a new non-deterministic failure?

boot-def-test: FAIL (0.92s)
  test\\exe\\Main.hs:3226:
  number of definitions
  expected: 1
   but got: 0

@Ailrun
Copy link
Member

Ailrun commented Mar 2, 2021

Yeah, it looks so...

@berberman
Copy link
Collaborator Author

This PR is ready for review.

@mergify mergify bot closed this in #1491 Mar 5, 2021
@berberman berberman deleted the typelens branch March 5, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeLens to add type signature inserts invalid type signature CodeLens to add type signature failed to deal with functions with * in their names
3 participants