Move Recorder logic to hls-plugin-api

[joyfulmantis]

We would like to be able to log problems that are obvious from either combineResponses or pluginEnabled, but currently, we can't as we don't have access to a Recorder. Passing in a recorder should be easy, as the functions in ghcide that call these functions have one, but because the Recorder type is defined in ghcide, and ghcide depends on hls-plugin-api, hls-plugin-api can't depend upon ghcide to import it. The solution to fix this is to move all the Recorder stuff from ghcide to hls-plugin-api

[michaelpj]

Yes, good idea. Not sure why it isn't there already.

[joyfulmantis]

Okay, I'll try to work on that then.

[joyfulmantis]

I overlooked that Recorder needs MonadIO. Is it still worth it in that case?

[joyfulmantis]

Fixed in PR #3714