July 2021 monthly release (1.3.0) with limited ghc 9.0 support (needs hackage release)

[jneira]

The release also would include, among other things:

• The lately amazing work done in the wingman plugin by @isovector
• Binaries for ghc-9.0.1 (thanks to @anka-213)
  • Those binaries dont include all plugins and did not pass the entire test suite but i think we could inlcude it with noting they are in beta state (would love to know your opinion about this)
• Artifacts for ghcup for the three os's and a SHA256SUMS with the checksums from all artifacts which could be gpg signed (not sure if we will able to sign them in this one though)
• Checklist of upstream packages we need up to date to make the hackage release:
  • ghc-api-compat:
    • https://github.com/hsyl20/ghc-api-compat/pull/11
    • https://gitlab.haskell.org/haskell/ghc-api-compat/-/issues/1#note_371055
    • cabal check doesn't account for conditionals cabal#4629
    • (pending pr to remove it from hls)
  • remove allow-newer: Clean cabal project #2097

[konn]

I think we could send to lsp clients, when called for ghc 9, some "warning" that noting GHC 9.0.1 support is in the beta stage with partial functionalities and pointing to GHC 9 tracking issue #297.
I think it is likely that some people might not be aware of release note (e.g. automaticaljy updated/installed by lsp client), and sporadically report it as independent issues - so some auxiliary pointer at the editor level could prevent such cases.

[jneira]

I think we could send to lsp clients, when called for ghc 9, some "warning" that noting GHC 9.0.1 support is in the beta stage with partial functionalities and pointing to GHC 9 tracking issue #297.

Good idea, a warning popup would be great

[anka-213]

Oh, does it no longer pass the test suite? What broke?

[jneira]

Oh, does it no longer pass the test suite? What broke?

Dont worry enabled tests are passing but afaics ghc-9.0 is not tested at all in windows and macOS and the tests of all plugins (execpt hls-haddock-comments-plugin), including the enabled ones for ghc-9.0 are not being executed.

After a deeper look, the hls test suite is being executed and some plugins still are included in it (all the enabled ones for ghc-9.0.1)

[jneira]

In fact we are not testing macOS at all 😟

[anka-213]

I have run all the tests manually on MacOS on my machine and they worked fine there last I checked. I don't know about windows. But yes, we could enable the tests for ghc9 on windows and macos at the cost of more CI time.

[anka-213]

(I believe both windows and macos are significantly more expensive than ubuntu for github's ci time calculations, but I don't know how that matters for this project)

[jneira]

I've activated test for windows and macOs in my repo, lets see how they are going: https://github.com/jneira/haskell-language-server/actions/runs/986014293

[jneira]

Not bad at all for Windows (the macOS job was cancelled):

1 out of 559 tests failed (1414.12s)

The failing test:

TH Splice Hover:                                                                                    FAIL (2.22s)
        test\exe\Main.hs:3560:
        failed to find: `Identity` in hover message:
        
        '''haskell
        id :: forall a. a -> a
        '''
        
        *Defined in 'GHC.Base'*
        
        
        
        * * *
        
        '''haskell
        _ :: Q Exp -> Q Exp
        '''

[konn]

I think we could send to lsp clients, when called for ghc 9, some "warning" that noting GHC 9.0.1 support is in the beta stage with partial functionalities and pointing to GHC 9 tracking issue #297.

Good idea, a warning popup would be great

OK, I'm tring this in #1992!

[jneira]

Would we want to see some pending pr in the next release? In the vscode extension side we have to add the alert when downloading 9.0

[jneira]

I am afraid i have not much free time as i would like to lately, if someone want to drive the release the work would be very welcomed 😟