This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Quickfix action to prefix unused terms with '_' #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test for this? |
|
Of course! |
|
I thought it was already on! |
|
Might be set to run PRs only after they are accepted? |
|
The circle ci issue was on my part. I had tinkered with it on my fork. And apparently if you watch a fork it dosen't build for PRs to upstream. |
alanz
reviewed
Oct 23, 2018
| cmdArgs = LSP.List | ||
| [ Object $ HM.fromList [("file", toJSON docUri),("pos", toJSON pos), ("text", toJSON newTerm)]] | ||
| -- The command label isen't used since the command is never presented to the user | ||
| cmd = LSP.Command "Unused command label" "hare:rename" (Just cmdArgs) |
There was a problem hiding this comment.
I love being able to do hare:rename as a command.
There was a problem hiding this comment.
Yes! I started by importing hare, then thought wait a minute...
lukel97
approved these changes
Oct 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #843