Skip to content

Update version to 2.47.0-pre1 (on v2.47.x branch) #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

jtattermusch
Copy link
Contributor

I'll create the prerelease and push the nuget packages after this PR gets merged.
Note that this is going to be the first release in which we publish the nuget packages that were recently moved from the grpc/grpc repository (e.g. Grpc.Core.Api)

CC @apolcyn

Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GrpcPackageVersion needs to be updated for new Grpc.Tools.

@jtattermusch
Copy link
Contributor Author

GrpcPackageVersion needs to be updated for new Grpc.Tools.

Done (bumped to 2.47.0 which just got released).

@jtattermusch
Copy link
Contributor Author

Looks like we'd need a few more adjustments - while GrpcPackageVersion is used mostly for Grpc.Tools package dependency, there are a few more place where it's used as a version for other packages:
https://github.com/grpc/grpc-dotnet/search?p=1&q=GrpcPackageVersion (e.g. Grpc.Core, Grpc.Core.Api etc.).
So it seems that we'll need to split GrpcPackageVersion property into more separate properties.
(e.g. GrpcToolsPackageVersion, GrpcCorePackageVersion and use the existing GrpcDotnetVersion as version for packages that have been moved to grpc-dotnet repo - Grpc.Core.Api etc.)

@jtattermusch jtattermusch force-pushed the jtattermusch-patch-47 branch from eca8045 to 057bc4d Compare June 23, 2022 11:35
@jtattermusch
Copy link
Contributor Author

Since #1785 is now both in master and in v2.47.x (and GrpcToolsPackageVersion is now at 2.47.0), simply updating version.props should be sufficient.

@jtattermusch jtattermusch merged commit 786818f into v2.47.x Jun 23, 2022
@jtattermusch
Copy link
Contributor Author

I just pushed the nugets (this time includes recently moved packages Grpc.Auth, Grpc.Core.Api, Grpc.Reflection, Grpc.HealthCheck).

https://github.com/grpc/grpc-dotnet/releases/tag/v2.47.0-pre1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants