Skip to content

Fix fragment name #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Fix fragment name #937

merged 2 commits into from
Nov 3, 2020

Conversation

doubledup
Copy link
Contributor

Conditional fragments aren't referenced anywhere else in the documentation,
going by results from the search bar. This is introduced as an inline fragment
in the "Queries and Mutations" section.

Conditional fragments aren't referenced anywhere else in the documentation,
going by results from the search bar. This is introduced as an inline fragment
in the "Queries and Mutations" section.
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I definitely agree that we should be using consistent terms to avoid confusion. Pinging @IvanGoncharov in case I'm missing something, but otherwise, I think this looks good to merge 💫

Thank you @doubledup 💐

@carolstran
Copy link
Member

Hey hey 👋🏼 We recently completed a Gatsby migration (#938), so could you please resolve the conflicts on your branch? Then I can merge.

@carolstran carolstran merged commit 33e3e9e into graphql:source Nov 3, 2020
Urigo pushed a commit that referenced this pull request Jan 26, 2021
Conditional fragments aren't referenced anywhere else in the documentation,
going by results from the search bar. This is introduced as an inline fragment
in the "Queries and Mutations" section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants