Skip to content

Fix wrong meaning in "thinking in graphs - legacy" #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

0000marcell
Copy link
Contributor

I think the "how" and "what" should be swapped here since it doesn't
make much sense based on the previous phrase.

I think the how and what should be swapped here, since it doens's
make much sense based on the previous phrase.
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 @0000marcell, thanks for taking the time to open a pull request! I agree that this is confusing and I would also assume that these two should be switched.

Pinging @IvanGoncharov in case I'm wrong - also since he'll be the one to merge once we're accepting content changes again.

@carolstran
Copy link
Member

Hey hey 👋🏼 We recently completed a migration to Gatsby (#938), so could you please resolve the conflicts on your branch? Then I can merge.

@0000marcell
Copy link
Contributor Author

I think it's everything ok now 👍

@carolstran carolstran merged commit 13816d9 into graphql:source Nov 5, 2020
Urigo pushed a commit that referenced this pull request Jan 26, 2021
I think the how and what should be swapped here, since it doens's
make much sense based on the previous phrase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants