Fix #831 - Search bar is getting out of the navbar when selected #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elit-altum
suggested changes
Feb 23, 2020
| @@ -27,7 +27,7 @@ | |||
| transition: width 0.2s ease-out; | |||
|
|
|||
| &:focus { | |||
| width: 300px; | |||
| width: 250px; | |||
There was a problem hiding this comment.
This much difference will then move it to the bottom on a smaller screen resolution. This may work on your screen size but will not in many others. This is not a permanent fix or solution.
There was a problem hiding this comment.
@elit-altum Yes, you are right. Actually we need a sidebar rather than navbar for smaller devices.
|
👋🏼 @ani4aniket, thanks for taking the time to make a pull request! As there are a couple PRs for this issue open, I'm going to close this one in favor of #841 as it incorporates media queries. I'd be super curious to hear your review of that PR if you have time 😊 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #831
