Skip to content

fix for issue #832 #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix for issue #832 #837

wants to merge 3 commits into from

Conversation

RoLoDeXx
Copy link
Contributor

Current behavior
Screenshot from 2020-02-23 00-37-16

After PR merge
Screenshot from 2020-02-23 00-38-44

@RoLoDeXx RoLoDeXx mentioned this pull request Feb 22, 2020
Copy link
Contributor

@elit-altum elit-altum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majority of your changes are indentation and line changes.
Revert them if possible and avoid them in future PRs as they distract from the core changes and might create merge conflicts for other developers working on something else.

Maybe you used a custom ESLint + Prettier setup on these files which might have caused the issue.

@RoLoDeXx
Copy link
Contributor Author

I have tweaked my prettier setup a bit to avoid indentation and line changes from now on.
Thanks for the heads up @elit-altum

@elit-altum
Copy link
Contributor

I have tweaked my prettier setup a bit to avoid indentation and line changes from now on.
Thanks for the heads up @elit-altum

@RoLoDeXx No problem!
You should proceed to squash your commits now.

@RoLoDeXx
Copy link
Contributor Author

I was having some troubles regarding the squashes so I've made a new PR for the same issue.
#839

I'll be closing this request

@RoLoDeXx RoLoDeXx closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants