Skip to content

Turn tags into links on tools-and-libraries page #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

kamilkisiela
Copy link
Contributor

@kamilkisiela kamilkisiela commented Dec 5, 2024

Adjust title and description when the list of selected tags changes.

I did that for a few reasons:

  • the only way to share the selected combination of tags was by copying the address from the address bar of the browser (or however you want to call it), now people can just right click on a tag and pick "Copy address".
  • google wasn't able to crawl each page individually, so we have only /community/tools-and-libraries in the search results.
  • to highlight every category and make it more friendly for google (proper title and description) - google will now be able to show "Javascript and Client | Tools and Libraries | GraphQL" page when somebody is searching for "graphql javascript clients". You get the idea :)
  • hierarchy of headings was messed up, because library's README content was rendered with h1,h2,h3 and so on, elements.

Adjust title and description when the list of selected tags changes
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 4:40pm

Copy link

vercel bot commented Dec 5, 2024

@kamilkisiela is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@Urigo Urigo self-requested a review December 5, 2024 16:49
@Urigo Urigo merged commit b00b699 into graphql:source Dec 5, 2024
4 checks passed
@kamilkisiela kamilkisiela deleted the kamil-code-shareable branch December 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants