graphql conf 2025 landing page #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@YassinEldeeb is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
dimaMachina
reviewed
Dec 18, 2024
| }} | ||
| ></div> | ||
| ))} | ||
| <a href={disabled ? undefined : href} className="relative z-0 col-span-8 row-span-2 text-white text-3xl font-semibold bg-[#E10098] hover:bg-[#ef00a3] flex items-center justify-center gap-2" |
There was a problem hiding this comment.
<a> without href is not good for SEO
better to use const ComponentToUse = disabled ? 'span' : 'a'
dimaMachina
reviewed
Dec 18, 2024
dimaMachina
reviewed
Dec 18, 2024
dimaMachina
reviewed
Dec 18, 2024
dimaMachina
reviewed
Dec 18, 2024
dimaMachina
reviewed
Dec 18, 2024
dimaMachina
reviewed
Dec 18, 2024
saihaj
reviewed
Dec 18, 2024
| @@ -34,6 +34,7 @@ | |||
| "hast-util-to-string": "3.0.1", | |||
| "iframe-resizer-react": "^1.1.0", | |||
| "leaflet": "^1.9.4", | |||
| "lucide-react": "^0.468.0", | |||
There was a problem hiding this comment.
forgive me; we have too many icon packages. Will figure out cleaning all of those....
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
saihaj
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.