Skip to content

Meenakshi dhanani postman description #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meenakshi-dhanani
Copy link
Contributor

Description

The PR updates the description of Postman, also modifies the URL it links to

Copy link

vercel bot commented Dec 28, 2023

@meenakshi-dhanani is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 1:33pm

@meenakshi-dhanani
Copy link
Contributor Author

Hey @Urigo, I was hoping merging this would update the Postman description. My bad; I should've checked before raising the PR. The description isn't updated, and locally, when I try to load the /code page, it gives me a 404.
Screenshot 2023-12-29 at 4 03 29 PM

@YassinEldeeb
Copy link
Contributor

YassinEldeeb commented Dec 29, 2023

Hey @meenakshi-dhanani! I have checked, and the reason it wasn't updated for graphql.org/code was because of a misconfiguration to Vercel's production deployment pipeline. I have fixed it and it should be updated now, and it should work as expected from now on with any other PRs.

And the reason it gives you 404 locally, is that the /code page is specifically configured to build for prod in a weird way that results in a 404 locally when running the gatsby dev server:

if (page.path === "/code" || page.path === "/code/") {
const markdownFilePaths = await glob("src/content/code/**/*.md")
const slugMap = require("./src/content/code/slug-map.json")
const codeData = await updateCodeData(markdownFilePaths, slugMap)
const organizeData = await organizeCodeData(codeData)
const sortedOrganizeData = await sortCodeData(organizeData)
context = {
sourcePath: path.relative(__dirname, page.path),
...sortedOrganizeData,
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants