fix canonical #1583
Merged
fix canonical #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ graphql.github.io-source deploy preview ready
|
benjie
reviewed
Oct 5, 2023
src/components/Conf/Seo/index.tsx
Outdated
| @@ -41,6 +42,9 @@ export default function SeoConf(props: { | |||
| <meta name="twitter:title" content={twitterTitle} /> | |||
| <meta name="twitter:description" content={description} /> | |||
| <meta name="twitter:image" content={image} /> | |||
| {props.pathname && ( | |||
| <link rel="canonical" href={`https://graphql.org/${props.pathname}`} /> | |||
There was a problem hiding this comment.
If pathname starts with a / then this will be an unpleasant URL.
Suggested change
| <link rel="canonical" href={`https://graphql.org/${props.pathname}`} /> | |
| <link rel="canonical" href={`https://graphql.org/${props.pathname.replace(/^[/]+/, '')}`} /> |
There was a problem hiding this comment.
previous solution didn't work, I replaced by gatsby plugin
dimaMachina
force-pushed
the
fix-canonical
branch
from
e1f5bdb to
9a1f3c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.