Update outdated bits related to graphql-over-http #1394
Conversation
|
@enisdenjo can you review? |
| A detailed [HTTP & websockets transport specification](https://github.com/graphql/graphql-over-http) is in development. Though it is not yet finalized, these draft specifications act as a single source of truth for GraphQL client & library maintainers, detailing how to expose and consume a GraphQL API using an HTTP transport. Unlike the language specification, adherence is not mandatory, but most implementations are moving towards these standards to maximize interoperability. |
There was a problem hiding this comment.
Also SSE transport.
Why's adherence not mandatory? In order to be GQL over HTTP compliant - it is mandatory. I'd recommend rephrasing or just removing this sentence altogether.
There was a problem hiding this comment.
It's not mandatory to be GraphQL compliant; you can be GraphQL compliant without being GraphQL-over-HTTP compliant. For example, persisted operations (over HTTP) still comply with the GraphQL spec but don't (currently) comply with GraphQL-over-HTTP.
Also I'd replace "HTTP & websockets & SSE" with just "HTTP" - all of these things are part of HTTP.
There was a problem hiding this comment.
FWIW I didn't actually make edits to this section (looks like my editor added a missing newline). But agree with @benjie 's suggestion here and will simplify this to just "HTTP"
|
@trevor-scheer we've just merged a change with prettier, could you please rebase? |
* The `application/graphql` content-type is no longer recommended via the graphql-over-http spec * The graphql-over-http spec makes no recommendation of parsing the `query` query parameter for POST requests
|
@Urigo no worries, done! |
|
thank you @trevor-scheer ! |
This PR removes and updates related to the graphql-over-http spec.
application/graphqlcontent-type has been superseded and shouldn't be recommended anymore