-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conf page #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conf page #1382
Conversation
Signed-off-by: Tuval <tuval.simha@gmail.com>
Signed-off-by: Tuval <tuval.simha@gmail.com>
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
Super excited to review this! Thank you for jumping on the task so quickly. I'm on my way into an airplane now so will review this a bit late, but in the meantime I've shared a bunch of prep docs with @Urigo so he should be equipped to help review until then |
The video is really promising. Great work so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when rendering the main page of graphql.org that the introduction of tailwind caused some h2 and img elements to display incorrectly.
Would you mind comparing old and new to ensure tailwind didn't break too many things?
I hope you don't mind I took the liberty of adding a batch of changes in the commit above. Still plenty of progress to be done, thanks for getting this going! |
* Moved all assets into a single dir * Set up subpages and corrected all links * Created main page banner * Minor style edits
I'm not very familiar with tailwind, but I think the rendering issue is that tailwind's reset CSS is getting added to the page after the full set of compiled less files, and _css/graphql.less has some resets of its own.
|
I was able to make a bit more progress and am signing off for a while. I'll check back in about 12hr to see if I can help from there. |
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
Signed-off-by: TuvalSimha <tuval.simha@gmail.com>
I've gotten all FAQ content in place. I noticed at some point with the revamped design that those pages lost styles. I think it's just a matter of styling header, ul, and a tags appropriately. I'm sure you're aware mobile views still has some layout issues as well I'll check back in morning my time to handle any loose ends, but if you think you have everything polished up and tested then you have my blessing to merge this |
@leebyron should we change "Register Now!" to something like "Buy Tickets" or something more simple? |
Ah looking good! On mobile I'm still seeing some layout issues with content wider than the screen width |
@leebyron can you share a screenshot? |
Hey @leebyron, how are you?
So Uri talks with me about the
/conf
page. For this moment this is a draft pull request, you can run it and explore the new path/conf
. This is not the final result of course, but I will be happy to get your feedback. I will continue with this work tomorrow.Missing: