Skip to content

Refactor /code page #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2022
Merged

Refactor /code page #1319

merged 3 commits into from
Dec 8, 2022

Conversation

dimaMachina
Copy link
Contributor

@dimaMachina dimaMachina commented Nov 25, 2022 •
edited
Loading

  • remove confusing buildLanguagesMenu, buildLibraryContent, buildLibraryList, buildLibraryCategoryContent and buildLanguagesContent functions and use React components instead
  • add missing fields for ILibrary interface
  • avoid using any
  • use rel="noreferrer" with target="_blank"

cc @TuvalSimha

@dimaMachina dimaMachina marked this pull request as ready for review December 8, 2022 13:38
@Urigo Urigo merged commit 2b95360 into graphql:source Dec 8, 2022
@Urigo
Copy link
Contributor

Urigo commented Dec 8, 2022

Thank you @B2o5T !

@dimaMachina dimaMachina deleted the refactor-code branch December 8, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaMachina @Urigo