-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add wundergraph to gateway section #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wundergraph to gateway section #1285
Conversation
👋 @jensneuse - thanks for this! Hmmm - I wonder if creating a new "Gateways" section on this page is getting a bit too specific, and breaks the more high-level type of bucketing in place on the page. Gateways are a pretty specific subset of "Tools", and there aren't (currently) a lot of GraphQL gateways out there, so I'm not sure if calling them out separately will add much value to folks visiting the page. Don't get me wrong, I will happily submit a PR to add Apollo Router if we want to create this new category 😂, but I think this extra category might be splitting things up a bit too much. That being said, I'd love to hear what others in @graphql/content think. |
Great ideas @jensneuse and @hwillson ! Adding a bit more context on the last overall we've mode for the code section, we had thought initially to create a couple of sub-categories under tools, but at the time there weren't enough, so we thought to leave it as general "tools" section and see when new things will up to differentiate. I think Gateways/Supergraphs looks like an important category and the fact that Apollo Router, Schema Stitching and other very popular and important tools are not represented here points to the fact we might want to add that section. I guess the open question for me would be if we want to add it to the top category (next to Also I can think of a couple of new subcategories of language agnostic tools, so I guess my vote is to put it as a first subsection under Also, personally I would name this category I will follow up on this PR with other tools that fit that subcategory and at least one more sub category. @jensneuse @hwillson does that fit your directions? |
That's in line with my thinking. What should we do with this PR? Should I make changes as you proposed? Do you want to take over and arrange the content properly? I have to admit I don't feel 100% comfortable with the codebase and don't want to introduce a new style or patterns when introducing this new category. |
sure, if you are not comfortable I can send a new PR instead. |
Thanks for the additional background @Urigo - this all sounds great to me! |
Ok, then I'd welcome if you can take over incorporating this PR into the new structure. Thanks. |
done in #1330 |
Description
As discussed with Uri, this adds WunderGraph to the newly created Gateway section.