Skip to content

feat: add wundergraph to gateway section #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jensneuse
Copy link
Contributor

Description

As discussed with Uri, this adds WunderGraph to the newly created Gateway section.

@hwillson
Copy link
Member

👋 @jensneuse - thanks for this!

Hmmm - I wonder if creating a new "Gateways" section on this page is getting a bit too specific, and breaks the more high-level type of bucketing in place on the page. Gateways are a pretty specific subset of "Tools", and there aren't (currently) a lot of GraphQL gateways out there, so I'm not sure if calling them out separately will add much value to folks visiting the page. Don't get me wrong, I will happily submit a PR to add Apollo Router if we want to create this new category 😂, but I think this extra category might be splitting things up a bit too much. That being said, I'd love to hear what others in @graphql/content think.

@Urigo
Copy link
Contributor

Urigo commented Nov 12, 2022

Great ideas @jensneuse and @hwillson !

Adding a bit more context on the last overall we've mode for the code section, we had thought initially to create a couple of sub-categories under tools, but at the time there weren't enough, so we thought to leave it as general "tools" section and see when new things will up to differentiate.

I think Gateways/Supergraphs looks like an important category and the fact that Apollo Router, Schema Stitching and other very popular and important tools are not represented here points to the fact we might want to add that section.

I guess the open question for me would be if we want to add it to the top category (next to tools) or a subcategory of tools.
Tools currently is focused on things that are language agnostic, which I believe Gateways and Supergraphs are, so if we follow that direction, it means as a subcategory under tools.

Also I can think of a couple of new subcategories of language agnostic tools, so I guess my vote is to put it as a first subsection under Tools and place all existing links under general subsection.

Also, personally I would name this category Gateways and Supergraphs as any GraphQL library could act as a gateway and I think the distinguishing factor here is a tool that orchestrates underlying, remote GraphQL servers, so the rename would make it more clear.

I will follow up on this PR with other tools that fit that subcategory and at least one more sub category.

@jensneuse @hwillson does that fit your directions?

@jensneuse
Copy link
Contributor Author

Great ideas @jensneuse and @hwillson !

Adding a bit more context on the last overall we've mode for the code section, we had thought initially to create a couple of sub-categories under tools, but at the time there weren't enough, so we thought to leave it as general "tools" section and see when new things will up to differentiate.

I think Gateways/Supergraphs looks like an important category and the fact that Apollo Router, Schema Stitching and other very popular and important tools are not represented here points to the fact we might want to add that section.

I guess the open question for me would be if we want to add it to the top category (next to tools) or a subcategory of tools.
Tools currently is focused on things that are language agnostic, which I believe Gateways and Supergraphs are, so if we follow that direction, it means as a subcategory under tools.

Also I can think of a couple of new subcategories of language agnostic tools, so I guess my vote is to put it as a first subsection under Tools and place all existing links under general subsection.

Also, personally I would name this category Gateways and Supergraphs as any GraphQL library could act as a gateway and I think the distinguishing factor here is a tool that orchestrates underlying, remote GraphQL servers, so the rename would make it more clear.

I will follow up on this PR with other tools that fit that subcategory and at least one more sub category.

@jensneuse @hwillson does that fit your directions?

That's in line with my thinking. What should we do with this PR? Should I make changes as you proposed? Do you want to take over and arrange the content properly? I have to admit I don't feel 100% comfortable with the codebase and don't want to introduce a new style or patterns when introducing this new category.

@Urigo
Copy link
Contributor

Urigo commented Nov 12, 2022

sure, if you are not comfortable I can send a new PR instead.
Let's wait for @hwillson's opinion first

@hwillson
Copy link
Member

Thanks for the additional background @Urigo - this all sounds great to me!

@jensneuse
Copy link
Contributor Author

sure, if you are not comfortable I can send a new PR instead. Let's wait for @hwillson's opinion first

Ok, then I'd welcome if you can take over incorporating this PR into the new structure. Thanks.

@Urigo
Copy link
Contributor

Urigo commented Dec 20, 2022

done in #1330

@Urigo Urigo closed this Dec 20, 2022
@jensneuse jensneuse deleted the feat/add-wundergraph-as-gateway branch December 20, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants