-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Schema Coordinates #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
magicmark
wants to merge
48
commits into
graphql:main
Choose a base branch
from
magicmark:schema_coordinates_spec_edit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Schema Coordinates #794
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
38616cc
Add Schema Coordinates RFC
magicmark 45fb46c
Update schema coordinates spec edit
magicmark eabdaff
implement PR suggestions
magicmark f994f99
Tweak example table wording
magicmark 17002d4
Apply suggestions from code review
magicmark 6456c5f
enumName -> enumValueName
magicmark 4905977
- Add PR feedback
magicmark 8be29ca
Update Section 3 -- Type System.md
magicmark 568d26f
Editorial on grammar and semantics
leebyron b8f3f47
Move section
leebyron 8580162
Simplify examples
leebyron 87a38e2
standalone
leebyron 75c48ba
update numbers
leebyron 148d073
clarify element
leebyron c43f4aa
Update Punctuator grammar
leebyron bb896cf
specify schema element
leebyron e5a2092
fix example
leebyron b65eb31
clarify metafields
leebyron c16a28b
Better Punctator
leebyron 93bd2c6
Minor algo variable name refinements
leebyron b2e42e8
whitespace fix
magicmark 4ce2d48
add note about union members
magicmark 2d60b33
prettier
magicmark d61cdc3
formatting
magicmark caed065
Update spec/Section 3 -- Type System.md
magicmark 07b3bbd
Update spec/Section 3 -- Type System.md
magicmark a3383ee
Merge branch 'main' into schema_coordinates_spec_edit
benjie 258d841
Run prettier
benjie 8a97138
add spec updates
magicmark c8a2cfe
Add back assertion
magicmark a96836a
assert that ... -> assert ...
magicmark 3effd4a
consistent periods
magicmark 9feceb2
consistent exists/must exist
magicmark 11b9e96
void -> null
magicmark 10742dd
remove note prefix for error throwing note
magicmark 4b9f37a
Various stylistic fixes
benjie 3555f57
Update spec/Section 3 -- Type System.md
magicmark a52e312
Update spec/Section 3 -- Type System.md
magicmark dc1374d
Apply benjie's suggestions from code review
magicmark 8c01802
split out SchemaCoordinate definition
magicmark b4f2515
Update spec/Section 3 -- Type System.md
magicmark 8584fa3
condense assertion
magicmark 37c9c10
more condensing
magicmark 87f6bd0
Update spec/Appendix B -- Grammar Summary.md
magicmark 1cbad5d
Use `::` syntax for enum values
benjie ff1ccb4
Merge pull request #1 from graphql/coloncolon
magicmark 7b75489
Revert "Use `::` syntax for enum values"
magicmark be6938c
revert back to MemberCoordinates
magicmark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.