internal: refresh port of v16 work to next #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is popular on google as an index page
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
This replaces our expensive method that changes the underlying V8 shape multiple times with a loop that preserves the identity as much as possible. ``` ⏱ Print kitchen sink document 1 tests completed. 2 tests completed. HEAD x 9,290 ops/sec ±0.21% x 1.51 KB/op (24 runs sampled) BASE x 2,645 ops/sec ±0.18% x 2.18 KB/op (11 runs sampled) ``` --------- Co-authored-by: Benjie <code@benjiegillam.com>
See graphql/graphql.github.io#1951 For someone following the tutorial they may well get as far as running the server (`node server.js`) and then attempt to visit their new API and get confused because they're met with an error such as `{"errors":[{"message":"Missing query"}]}`. This PR adds some joining text to make it clear this is the expected outcome, and they must read on to get the GraphiQL IDE set up so that they can write queries.
…raphql#4343) * removes extra parenthesis from getting started code snippet
Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
See: [Archived repo](https://github.com/html5rocks/www.html5rocks.com/blob/master/content/tutorials/es6/promises/en/index.html#L6) redirected the links.
Issue The server throws an error because the root variable is not defined. The correct variable name should be rootValue, which was previously declared in the code. Fix Updated rootValue in the createHandler function to use the correct variable name. Changes Replaced root with rootValue in the GraphQL handler configuration.
…raphql#4366) This PR add `executionOptions` property to the `ExecutionArgs`. Currently only one option can be configured, as is the one I need, but I have built an object so it can easily be extended in the future. The property allows the configuration of the maximum number of errors (`maxErrors`) for coercion. This allows the current hardcoded limit (`50`) to be reduced to a small number to avoid possible DoS attacks. > Also, it updates the execution docs to reflect this new change. I think the documentation was outdated since functions were using positional arguments and now they only accept an object. No longer updates the docs.
This refactors the code-first examples to use inline-resolvers rather than the root-value to show a difference between SDL and code-first.
Follow up to graphql#4378
adds anatomy of a resolver guide This is a part of the effort to expand GraphQL.js documentation
Adds a guide "Understanding GraphQL.js Errors" I added some additional resources, feel free to suggest others/more if needed Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
As discussed at the GraphQL working group (via graphql/graphql-wg#1614 and at various meetings) and as agreed in last weeks meeting, the GraphQL.JS version policy as drafted by @JoviDeCroock has been approved and aligns with the informal policy we already had in place. As such, I have added it to the README. This PR also promotes a few headings (H3 -> H2) to make more structural sense in the TOC.
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Relevant to these PRs: - graphql#4380 - graphql#4381 - graphql#4382 - graphql#4383 - graphql#4391 In general this content was excellent - thanks @sarahxsanders! - but I wanted to add a few minor updates. I've included comments in a few places with reasoning. If this PR is too much to review all at once, I'm happy to break it up as I did review of each PR separately.
Co-authored-by: Benjie <benjie@jemjie.com>
This was referenced May 27, 2025
Closed
yaacovCR
changed the title
Adds guide "Using Directives in GraphQL.js"
Adds "Nullability in GraphQL.js" guide
Guide for subscriptions
Adds page on authorization strategies, right after authentication/middleware page Also adds a "Before you start" section about using ESM syntax JS code snippets --------- Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Updates "Going to Production" guide to cover a larger scope. The goal is to cover most bases on what devs should consider before deploying to production. I also added a checklist. --------- Co-authored-by: Benjie <benjie@jemjie.com>
Adds guide on caching strategies --------- Co-authored-by: Benjie <benjie@jemjie.com>
adds guide on Scaling your API, covering monoliths, schema stitching, and federation --------- Co-authored-by: Benjie <benjie@jemjie.com>
Expands on graphql#4398 by recommending the trusted documents pattern which 90+% of GraphQL users should be using.
Adds new guide: Type Generation for GraphQL Servers This is a part of the effort to expand GraphQL.js documentation --------- Co-authored-by: Eddy Nguyen <github@eddeee888.me> Co-authored-by: Benjie <benjie@jemjie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refreshes #4388 with each of the commits (hopefully) passing ci so that we can merge with rebase strategy