resources/utils.ts: npm/git will inherit stdout by default #3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Motivation: it's hard to debug scripts if stdout is not inherit at the same time we need to capture output of some git/npm commands. AFAIK node.js doesn't allow both "inherit" and "pipe" stdout, so instead we create wrapper for npm/git where subcommands that doesn't return values just "inherit" stdout.
IvanGoncharov
force-pushed
the
pr_branch
branch
from
dc88df1 to
aa6fdf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: it's hard to debug scripts if stdout is not inherit
at the same time we need to capture output of some git/npm commands.
AFAIK node.js doesn't allow both "inherit" and "pipe" stdout, so
instead we create wrapper for npm/git where subcommands that doesn't
return values just "inherit" stdout.