Skip to content

buildASTSchema: pass empty schema as literal #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020
Merged

buildASTSchema: pass empty schema as literal #2607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/utilities/buildASTSchema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ export function buildASTSchema(
assertValidSDL(documentAST);
}

const emptySchemaConfig = {
description: undefined,
types: [],
directives: [],
extensions: undefined,
extensionASTNodes: [],
assumeValid: false,
};
const config = extendSchemaImpl(emptySchemaConfig, documentAST, options);

if (config.astNode == null) {
Expand Down Expand Up @@ -114,8 +122,6 @@ export function buildASTSchema(
return new GraphQLSchema(config);
}

const emptySchemaConfig = new GraphQLSchema({ directives: [] }).toConfig();

/**
* A helper function to build a GraphQLSchema directly from a source
* document.
Expand Down