Skip to content

fix(query): support for nameless queries with vars #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/query/format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ impl<'a, T: Text<'a>> Displayable for Query<'a, T>
if let Some(ref name) = self.name {
f.write(" ");
f.write(name.as_ref());
if !self.variable_definitions.is_empty() {
f.write("(");
self.variable_definitions[0].display(f);
for var in &self.variable_definitions[1..] {
f.write(", ");
var.display(f);
}
f.write(")");
}
if !self.variable_definitions.is_empty() {
f.write("(");
self.variable_definitions[0].display(f);
for var in &self.variable_definitions[1..] {
f.write(", ");
var.display(f);
}
f.write(")");
}
format_directives(&self.directives, f);
f.write(" ");
Expand Down
4 changes: 4 additions & 0 deletions tests/queries/query_nameless_vars.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
query($first: Int, $second: Int) {
field1(first: $first)
field2(second: $second)
}
16 changes: 16 additions & 0 deletions tests/queries/query_nameless_vars_multiple_fields.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
,,,,,,,,,,,,,,,,,
query ,,,,,,, ($houseId: String!, $streetNumber: Int!) ,,,,,,,,,,,, { # comment
,,,,,,,,,,,,,,,,,, # commas should be fine
house(id: $houseId) {
id
name
lat
lng
}
street(number: $streetNumber) { # this is a comment
id
}
houseStreet(id: $houseId, number: $streetNumber) {
id
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
query($houseId: String!, $streetNumber: Int!) {
house(id: $houseId) {
id
name
lat
lng
}
street(number: $streetNumber) {
id
}
houseStreet(id: $houseId, number: $streetNumber) {
id
}
}
2 changes: 2 additions & 0 deletions tests/query_roundtrips.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ fn roundtrip2(filename: &str) {
#[test] fn minimal_query() { roundtrip("minimal_query"); }
#[test] fn named_query() { roundtrip("named_query"); }
#[test] fn query_vars() { roundtrip("query_vars"); }
#[test] fn query_nameless_vars() { roundtrip("query_nameless_vars"); }
#[test] fn query_nameless_vars_multiple_fields() { roundtrip2("query_nameless_vars_multiple_fields"); }
#[test] fn query_var_defaults() { roundtrip("query_var_defaults"); }
#[test] fn query_var_defaults1() { roundtrip("query_var_default_string"); }
#[test] fn query_var_defaults2() { roundtrip("query_var_default_float"); }
Expand Down