Skip to content

Use thiserror crate instead of failure #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Use thiserror crate instead of failure #30

merged 1 commit into from
Mar 15, 2020

Conversation

tailhook
Copy link
Collaborator

While failure still gets a lot of downloads rust community is more or less steering towards using (and fixing) stdlib error type.

Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@tailhook tailhook merged commit 65b0250 into master Mar 15, 2020
@tailhook tailhook deleted the errors branch March 15, 2020 10:38
Geal pushed a commit to apollographql/router that referenced this pull request Jul 8, 2022
This removes the deprecated `failure` crate from the dependency graph.

This should fix automated reports about
[GHSA-jq66-xh47-j9f3](GHSA-jq66-xh47-j9f3)

Related changes:
- apollographql/rover#1158
- graphql-rust/graphql-parser#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants