Skip to content

refs #439. Fix skip_serializing_none for root level variables #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2025
Merged

refs #439. Fix skip_serializing_none for root level variables #485

merged 3 commits into from
Jan 31, 2025

Conversation

elimirks
Copy link
Contributor

@elimirks elimirks commented May 19, 2024 •
edited
Loading

  • Check if root level variables are Option values and skip serializing with serde if the skip_serializing_none option is set
  • Update test case appropriately

@elimirks elimirks mentioned this pull request May 19, 2024
Closed
@tomhoule
Copy link
Member

Thanks for the PR! Sorry for the long reaction time, nobody was really maintaining this crate, I'm coming back to more active maintainership.

@tomhoule tomhoule merged commit a10c2af into graphql-rust:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elimirks @tomhoule