Skip to content

Update arg parsing to clap v3 #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Update arg parsing to clap v3 #409

merged 1 commit into from
Jan 20, 2022

Conversation

tranzystorekk
Copy link
Contributor

Updates arg parsing to the recently released clap 3 with the derive feature (the new structopt).

Changes in clap-derive:

  • Version is no longer propagated to the subcommands by default
  • Help output is colored by default

tomhoule
tomhoule approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

@tomhoule tomhoule merged commit 143c948 into graphql-rust:main Jan 20, 2022
@tranzystorekk tranzystorekk deleted the clap-v3 branch January 20, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tranzystorekk @tomhoule