Skip to content

Add feature to use reqwest with rustls rather than native-tls. #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Jan 3, 2022

Currently, enabling the reqwest feature pulls in native-tls. This is annoying in a project that otherwise uses rustls. This change adds a new feature reqwest-rustls that also adds the reqwest module, but using reqwest with rustls rather than native-tls.

Currently, enabling the reqwest feature pulls in native-tls. This is
annoying in a project that otherwise uses rustls. This change adds a new
feature 'reqwest-rustls' that also adds the reqwest module, but using
reqwest with rustls rather than native-tls.
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Have you had a chance to try this branch?

@qwandor
Copy link
Contributor Author

qwandor commented Jan 24, 2022

Yes, it works for me: qwandor/octopower#3

@tomhoule
Copy link
Member

Great, let's merge then :)

@tomhoule tomhoule merged commit 58ed885 into graphql-rust:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants