Added extension support #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
reviewed
Dec 4, 2021
graphql_client/src/lib.rs
Outdated
| @@ -288,6 +290,8 @@ pub struct Response<Data> { | |||
| pub data: Option<Data>, | |||
| /// The top-level errors returned by the server. | |||
| pub errors: Option<Vec<Error>>, | |||
| /// The top-level errors returned by the server. | |||
There was a problem hiding this comment.
The doc string should probably say something else. Ideally a short explanation with a link to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for extensions as a
serde_json::Value. This can be further converted into a concrete type with the use ofserde_json::from_value.Related: #367