Annotate variable struct fields too #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I don't remember the details of the code, so I can't say in detail, but it looks like a good change. Would it be easy to write a test for? That would make sure we don't introduce a regression in the future. |
|
@tomhoule Thank you for the suggestion. Proc-macros are rather difficult to test on its own, so I have decided to put a test in |
|
Hi @tomhoule. Do you think the newly added test sufficient for preventing future regression? |
| value | ||
| .as_object() | ||
| .unwrap() | ||
| .get("extern") |
There was a problem hiding this comment.
An assertion is made here so that the original field extern of the query variable is sent to the GraphQL server, instead of extern_ which mostly likely gets ignored.
tomhoule
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to properly rename variable struct fields.
Before this PR, variable field names do not carry
#[serde]annotation that establishes mapping between the safe name and the original schema name. With this PR, the derive macro will attach those annotation labels to renamed fields.This is important, because some GraphQL query input containing
wherefield, which is fairly common by the way, and the derive macro maps it towhere_. Without the annotation, this field gets serialized towhere_, which the GraphQL server will certainly not recognize.