Use async/await and exclusively futures 0.3. #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade wasm-bindgen-futures to 0.4 incl. related test package. Upgrade reqwest to 0.10 and remove unused dependency.
|
Thanks for the PR! Note that the custom web client will disappear after #338, but in the meantime it's a win. |
siedentop
pushed a commit
to siedentop/graphql-client
that referenced
this pull request
Nov 18, 2020
This was introduced in graphql-rust#350. Besides this, my thanks for upgrading reqwest. The old version cost me some time yesterday.
siedentop
pushed a commit
to siedentop/graphql-client
that referenced
this pull request
Nov 20, 2020
No idea whence this came. ¯\_(ツ)_/¯ Wasn't present in graphql-rust#350 and this branch does not touch anything there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade wasm-bindgen-futures to 0.4 incl. related test package.
Upgrade reqwest to 0.10 and remove unused dependency.
This is a breaking change, so a version bump is also needed.