Skip to content

Feat: allow disabling derive #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

jkelleyrtp
Copy link
Contributor

@jkelleyrtp jkelleyrtp commented Sep 30, 2020

The manual generation tool is enough for me, and the derive crate brings in a lot of overhead. This PR allows clearing the derive feature to use statically-generated types.

Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good! Just one question.

@jkelleyrtp jkelleyrtp requested a review from tomhoule September 30, 2020 17:06
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

I'll do a release next time I have a few hours to work on graphql_client.

@tomhoule tomhoule merged commit 64c0fea into graphql-rust:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants