Skip to content

Small cleanup to satisfy clippy and remove unneeded dependency on future in example #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Small cleanup to satisfy clippy and remove unneeded dependency on future in example #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions examples/web/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[package]
name = "web"
version = "0.1.0"
authors = ["Tom Houlé <tom@tomhoule.com>"]
edition = "2018"
name = "web"
version = "0.1.0"

# https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#profile-overrides
#[profile.release]
Expand All @@ -12,26 +12,25 @@ edition = "2018"
crate-type = ["cdylib", "rlib"]

[dependencies]
graphql_client = { path = "../../graphql_client", features = ["web"] }
graphql_client = {path = "../../graphql_client", features = ["web"]}
js-sys = "0.3.44"
lazy_static = "1.4"
serde = {version = "1.0.114", features = ["derive"]}
wasm-bindgen = "^0.2"
serde = { version = "1.0.67", features = ["derive"] }
lazy_static = "1.0.1"
js-sys = "0.3.6"
futures = "0.3.5"
wasm-bindgen-futures = "0.4.12"
wasm-bindgen-futures = "0.4.17"

[dependencies.web-sys]
version = "0.3.6"
features = [
"console",
"Document",
"Element",
"EventTarget",
"Node",
"HtmlBodyElement",
"HtmlDocument",
"HtmlElement",
"console",
"Document",
"Element",
"EventTarget",
"Node",
"HtmlBodyElement",
"HtmlDocument",
"HtmlElement",
]
version = "0.3.6"

# [[example]]
# name = "web"
Expand Down
1 change: 0 additions & 1 deletion examples/web/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use futures::{Future, FutureExt};
use graphql_client::{web, GraphQLQuery, Response};
use lazy_static::*;
use std::{cell::RefCell, sync::Mutex};
Expand Down
26 changes: 13 additions & 13 deletions graphql_client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
[package]
name = "graphql_client"
version = "0.9.0"
authors = ["Tom Houlé <tom@tomhoule.com>"]
description = "Typed GraphQL requests and responses"
repository = "https://github.com/graphql-rust/graphql-client"
license = "Apache-2.0 OR MIT"
keywords = ["graphql", "api", "web", "webassembly", "wasm"]
categories = ["network-programming", "web-programming", "wasm"]
description = "Typed GraphQL requests and responses"
edition = "2018"
keywords = ["graphql", "api", "web", "webassembly", "wasm"]
license = "Apache-2.0 OR MIT"
name = "graphql_client"
repository = "https://github.com/graphql-rust/graphql-client"
version = "0.9.0"

[dependencies]
anyhow = {version = "1.0", optional = true}
doc-comment = "^0.3"
anyhow = { version = "1.0", optional = true }
thiserror = { version = "1.0", optional = true }
graphql_query_derive = { path = "../graphql_query_derive", version = "0.9.0" }
graphql_query_derive = {path = "../graphql_query_derive", version = "0.9.0"}
reqwest = {version = "0.10.7", optional = true}
serde = {version = "^1.0.78", features = ["derive"]}
serde_json = "1.0"
serde = { version = "^1.0.78", features = ["derive"] }
reqwest = { version = "0.10.4", optional = true }
thiserror = {version = "1.0", optional = true}

[target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies]
reqwest = "^0.9"
# [target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies]
# reqwest = "^0.9"
Comment on lines +21 to +22
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure why this was here in the first place, removing it seemed to resolve some issues I had. But since i did not understand it completely, I left it in here as comments for now


[features]
web = ["reqwest"]