Allow disabling ssl verification on schema introspection #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomhoule please could you help take a look at this PR? As far as I can tell, the wasm test failure doesn't seem to be due to these changes. |
|
It's an additional feature to maintain if we want to switch client, but I think it's fine. I'm trying to minimize the scope as much as possible, since as you noticed, I don't have lots of free time for non-work projects at the moment. Thanks for the PR :) |
|
Thanks @tomhoule 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Introduces a flag for disabling SSL verification when using the
introspect-schemacommand:no_ssl: set this to disable SSL verification. The default value is false, so if the flag is not passed, SSL verification will be enabled.Why
My team recently decided to use
graphql_client_clifor introspecting our GraphQL services but quickly realized that there was no way to do this on a host where https is enabled, hence this flag.Sample Usage:
$ graphql-client introspect-schema https:/localhost:8080/graphql --no-ssl --header 'Authorization: Basic a5WcefsppefwfeX2pB25Z3JhtleQ='