Skip to content

[WIP] [web] Replace custom HTTP client with external crate #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

tomhoule
Copy link
Member

@tomhoule tomhoule commented May 17, 2020

This simplifies things a lot, and we benefit from other people's work on HTTP in the browser.

Current status: the web example works.

tomhoule added 2 commits May 17, 2020 11:03
This simplifies things a lot, and we benefit from other people's work on
HTTP in the browser.
@kellpossible
Copy link

kellpossible commented Jun 12, 2020

I noticed reqwest is missing a number of features for its wasm implementation, that won't affect this implementation will it?

@kellpossible
Copy link

kellpossible commented Jun 12, 2020

reqwest also appears to bring in quite a few more dependencies, how does that compare to this original implementation?

Edit: nevermind, actually it seems like most of them are excluded for the wasm version.

@tomhoule
Copy link
Member Author

The main reason behind this is that there isn't a lot of active contributions to this crate, so I'd like to avoid having the maintenance burden of a custom HTTP client for the browser, so we can focus the little time we have on more graphql-related problems.

@kellpossible
Copy link

@tomhoule sounds reasonable, thanks for the reply!

@MidasLamb
Copy link

For me this branch seems to work (for wasm target). Could I help with this PR to get it through CI?

MidasLamb and others added 2 commits July 29, 2020 20:53
@Type1J
Copy link

Type1J commented Aug 26, 2020

How's this PR going? Any help needed?

@MidasLamb
Copy link

@Type1J , I think the maintainer is quite busy at the moment. I've created #338 which should help this along.

@tomhoule
Copy link
Member Author

I'm indeed very busy, but I'm not the only maintainer and I am happy to review pull requests :) I hope I'll find a few hours for graphql-client next month.

@tomhoule
Copy link
Member Author

I just noticed #338 is no longer WIP - I'll find time to review it soon. If not feel free to ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants