-
Notifications
You must be signed in to change notification settings - Fork 163
[WIP] [web] Replace custom HTTP client with external crate #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This simplifies things a lot, and we benefit from other people's work on HTTP in the browser.
I noticed reqwest is missing a number of features for its wasm implementation, that won't affect this implementation will it? |
reqwest also appears to bring in quite a few more dependencies, how does that compare to this original implementation? Edit: nevermind, actually it seems like most of them are excluded for the wasm version. |
The main reason behind this is that there isn't a lot of active contributions to this crate, so I'd like to avoid having the maintenance burden of a custom HTTP client for the browser, so we can focus the little time we have on more graphql-related problems. |
@tomhoule sounds reasonable, thanks for the reply! |
For me this branch seems to work (for wasm target). Could I help with this PR to get it through CI? |
Small cleanup to satisfy clippy and remove unneeded dependency on future in example
How's this PR going? Any help needed? |
I'm indeed very busy, but I'm not the only maintainer and I am happy to review pull requests :) I hope I'll find a few hours for graphql-client next month. |
I just noticed #338 is no longer WIP - I'll find time to review it soon. If not feel free to ping me. |
This simplifies things a lot, and we benefit from other people's work on HTTP in the browser.
Current status: the web example works.