Skip to content

Drop anyhow #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2020
Merged

Drop anyhow #324

merged 3 commits into from
May 17, 2020

Conversation

tomhoule
Copy link
Member

Motivation:

  • It's one dependency fewer
  • Using our own error types will let us slowly improve error reporting

@tomhoule
Replace anyhow with custom error types
499d824 
Motivation: one dependency fewer.
@tomhoule
Copy link
Member Author

Next after this PR, I want to replace our hacked together custom HTTP client for the browser feature with an external crate, maybe reqwest.

h-michael
h-michael reviewed May 17, 2020
View reviewed changes
Copy link
Member

@h-michael h-michael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Would you fix fmt and clippy errors?

@tomhoule
Copy link
Member Author

Will do :)

@tomhoule tomhoule merged commit 32cd3c7 into master May 17, 2020
@tomhoule tomhoule deleted the drop-anyhow branch July 4, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-michael h-michael h-michael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomhoule @h-michael